Help and about screen needs an uplift in gui #10

New Issue

MichaelYick · 2021-06-13T01:42:55Z

MichaelYick commented

2021-06-13 01:42:55 +00:00

![image]()

image.png

15 KiB

MichaelYick added the

enhancement

label 2021-06-13 01:42:55 +00:00

MichaelYick added the

Low Priority

label 2021-06-13 01:55:43 +00:00

Nio commented

2021-06-15 03:49:26 +00:00

Minor note here, on Windows the icon for the game defaults to the Ren'py fallback. Windows is somewhat retarded and can only use .ico apparently. I did a conversion of the intended png to ico.
Minor thing, but was triggering my OCD.

Uh... I tried uploading here, not sure if it did.

Minor note here, on Windows the icon for the game defaults to the Ren'py fallback. Windows is somewhat retarded and can only use .ico apparently. I did a conversion of the intended png to ico. Minor thing, but was triggering my OCD. Uh... I tried uploading here, not sure if it did.

MichaelYick commented

2021-06-15 03:57:11 +00:00

@Nio
wrong place to put this, make a Pull Request for this please!

@Nio wrong place to put this, make a Pull Request for this please!

Nio commented

2021-06-15 05:38:11 +00:00

@Nio
wrong place to put this, make a Pull Request for this please!

@PrincipalSpears , on it. Should I create a new branch for this and then merge it into 'updates' ? Or should I use updates directly instead?
Not entirely sure what the etiquette is.
Just to perhaps elaborate how I'm used to working with git/bitbucket:
-People create their own branches (feature or fix) to work on things.
-There is a dev branch which gets all the updates from people's branches. This is where QA happens.
-There is a release branch which is then considered to be ready to merge to master.
-Merge to master, discard feature and fix branches if they went into release.

> @Nio > wrong place to put this, make a Pull Request for this please! @PrincipalSpears , on it. Should I create a new branch for this and then merge it into 'updates' ? Or should I use updates directly instead? Not entirely sure what the etiquette is. Just to perhaps elaborate how I'm used to working with git/bitbucket: -People create their own branches (feature or fix) to work on things. -There is a dev branch which gets all the updates from people's branches. This is where QA happens. -There is a release branch which is then considered to be ready to merge to master. -Merge to master, discard feature and fix branches if they went into release.

MichaelYick commented

2021-06-15 06:04:13 +00:00

we work pretty similar to that here. Just replace "create your own branch" with "fork and work in your own repo until you think your repo is PR ready". Im going to make a UI extras and enhancement branch, so all PRs should go to that rather than updates. Updates will depend on this.

👍 1

MichaelYick referenced this issue

2021-06-16 09:20:51 +00:00

Fixes #19 - Extras menu #29

Nio commented

2021-06-24 10:51:48 +00:00

Should we keep this issue open?