Coreography currently sucks, should be improved #12

New Issue

MichaelYick · 2021-06-13T01:46:53Z

MichaelYick commented

2021-06-13 01:46:53 +00:00

Both the team itself and outsiders have stated the coreography needs some work. This should be tackled eventually but will be quite the undertaking.

1.first-two-days-anon-meets-fang.rpy
2.fourth-day-of-school.rpy
3.showing-up-at-band-practice-and-giving-feedback.rpy
4.anon-needs-help-during-music-period.rpy
5.fang-and-anon-cut-class-to-talk-on-the-roof.rpy
6.anon-helps-fang-find-a-venue-for-band.rpy
7.concert-day.rpy
8.anon-and-fang-study-together.rpy
9.anons'-dirty-laundry-gets-put-up-to-air.rpy
10.an-excellent-reason-to-start-abusing-mod-powers.rpy
11A.fang-desperately-wants-to-win-prom-night.rpy
11B.anon-gets-fangs'-pronouns-right,-and-she's-smug-about-it.rpy
11C.anon-gets-fangs'-pronouns-right,-but-she-tells-him-she's-okay-with-being-called-a-girl.rpy
11D.anon-gets-fangs'-pronouns-right-and-she-teases-him-while-carrying-herself-with-more-confidence.rpy
11.school-assignment-and-route-lock.rpy
12A.music-museum-date.rpy
12B.band-fang-likes-concert.rpy
12C.anon-fang-lovey-dovey.rpy
12D.aquarium.rpy
13A.fang-loses-it-after-losing-prom-queen.rpy
13B.fang-breaks-up-with-anon.rpy
13C.fang-and-anon-go-to-beach-and-prom.rpy
13D.fang-plays-well,-naomi-jealous,-fang-talks-to-anon-to-break-up-while-she-thinks-about-her-life.rpy
14A.KO_OP-ending.rpy
14B.bad-ending.rpy
14C.good-ending.rpy
14D.gold-ending.rpy

Original:
Some have complained that anon needs to be more emotive to compensate for his lack of face. We do have sprites in there for use and sprinkling some in emotive sections seems like a good idea.

Both the team itself and outsiders have stated the coreography needs some work. This should be tackled eventually but will be quite the undertaking. - [ ]1.first-two-days-anon-meets-fang.rpy - [ ]2.fourth-day-of-school.rpy - [ ]3.showing-up-at-band-practice-and-giving-feedback.rpy - [ ]4.anon-needs-help-during-music-period.rpy - [ ]5.fang-and-anon-cut-class-to-talk-on-the-roof.rpy - [ ]6.anon-helps-fang-find-a-venue-for-band.rpy - [ ]7.concert-day.rpy - [ ]8.anon-and-fang-study-together.rpy - [ ]9.anons'-dirty-laundry-gets-put-up-to-air.rpy - [ ]10.an-excellent-reason-to-start-abusing-mod-powers.rpy - [ ]11A.fang-desperately-wants-to-win-prom-night.rpy - [ ]11B.anon-gets-fangs'-pronouns-right,-and-she's-smug-about-it.rpy - [ ]11C.anon-gets-fangs'-pronouns-right,-but-she-tells-him-she's-okay-with-being-called-a-girl.rpy - [ ]11D.anon-gets-fangs'-pronouns-right-and-she-teases-him-while-carrying-herself-with-more-confidence.rpy - [ ]11.school-assignment-and-route-lock.rpy - [ ]12A.music-museum-date.rpy - [ ]12B.band-fang-likes-concert.rpy - [ ]12C.anon-fang-lovey-dovey.rpy - [ ]12D.aquarium.rpy - [ ]13A.fang-loses-it-after-losing-prom-queen.rpy - [ ]13B.fang-breaks-up-with-anon.rpy - [ ]13C.fang-and-anon-go-to-beach-and-prom.rpy - [ ]13D.fang-plays-well,-naomi-jealous,-fang-talks-to-anon-to-break-up-while-she-thinks-about-her-life.rpy - [ ]14A.KO_OP-ending.rpy - [ ]14B.bad-ending.rpy - [ ]14C.good-ending.rpy - [ ]14D.gold-ending.rpy Original: Some have complained that anon needs to be more emotive to compensate for his lack of face. We do have sprites in there for use and sprinkling some in emotive sections seems like a good idea.

MichaelYick added the

enhancement

label 2021-06-13 01:46:53 +00:00

MichaelYick added the

Medium Priority

label 2021-06-13 01:54:14 +00:00

Ghost commented

2021-06-15 20:29:42 +00:00

Noticed some conversation about more emotion in general. A lot of which should be doable with available assets.

Anons are somehow still confused about how Trish gets the photos, and adding a flipped variant of trish_considering into the Rock bottom scene (~ line 11357) before switching back to neutral seems to clear that up for some.

Also Hello, unsure of ediquette here so if I fuck up just yell at me.

Noticed some conversation about more emotion in general. A lot of which should be doable with available assets. Anons are somehow still confused about how Trish gets the photos, and adding a flipped variant of trish_considering into the Rock bottom scene (~ line 11357) before switching back to neutral seems to clear that up for some. Also Hello, unsure of ediquette here so if I fuck up just yell at me.

MichaelYick commented

2021-06-15 23:31:14 +00:00

Noticed some conversation about more emotion in general. A lot of which should be doable with available assets.

Now that you mention it, yeah that seems to be accurate. I'll rename this issue too adjust to this. Artists and Writers have been complaining about the coreography. Fun fact, I was the one who did all of the coreography (And it fucking shows lmao).

unsure of ediquette

Its fine man, just keep convos tangential to the topic at hand and you'll be fine.

>Noticed some conversation about more emotion in general. A lot of which should be doable with available assets. Now that you mention it, yeah that seems to be accurate. I'll rename this issue too adjust to this. Artists and Writers have been complaining about the coreography. Fun fact, I was the one who did all of the coreography (And it fucking shows lmao). >unsure of ediquette Its fine man, just keep convos tangential to the topic at hand and you'll be fine.

MichaelYick changed title from ~~Anon's not as emotive as he could be~~ to Coreography currently sucks, should be improved

2021-06-15 23:31:55 +00:00

MichaelYick added a new dependency 2021-06-15 23:33:29 +00:00

#17 Fixes #2 - Refactoring Code so its not one 28k line blob

Bowie commented

2021-06-17 20:48:58 +00:00

I can see this being a long slog, but live script reloading should take some of the edge off. @PrincipalSpears what was your experience of debugging the stage directions when you were battling alone, did you settle on a comfortable workflow?

I was also wondering if the scope here is limited to VFX, sprite control and that or whether it extends to text tagging as well, since that involves us autistic code monkeys potentially taking some artistic liberties with how the script is delivered - IMO that should be done with at least some supervision, input or feedback from the original author.

I can see this being a long slog, but [live script reloading](https://www.renpy.org/doc/html/developer_tools.html#shift-r-reloading) should take some of the edge off. @PrincipalSpears what was your experience of debugging the stage directions when you were battling alone, did you settle on a comfortable workflow? I was also wondering if the scope here is limited to VFX, sprite control and that or whether it extends to text tagging as well, since that involves us autistic code monkeys potentially taking some artistic liberties with how the script is delivered - IMO that should be done with at least some supervision, input or feedback from the original author.

MichaelYick commented

2021-06-17 23:34:16 +00:00

I can see this being a long slog, but live script reloading should take some of the edge off.

Trust me man, i've been using that since I discovered it while working on chapter 2.

what was your experience of debugging the stage directions when you were battling alone, did you settle on a comfortable workflow?

Mostly, it was as follows:

Imagine what each of the characters would look like in certain places
Put sprites on screen in places I think they'll go
Reload the scene and check out if somethings wrong
If it is, correct slowly until I moved on

This was tedius, took way too much time, and, near the end, Some of the more granular control was simply not time effective (we were aiming for /v/3). The entire process of coreography is very time consuming and with little shortcuts.

I only really fixed what was complained about and no one really complained about what was wrong until near the end.

I was also wondering if the scope here is limited to VFX, sprite control and that or whether it extends to text tagging as well

I used to manually tag text in chapter 1 until I realized how utterly miserable it was. From there, I told the writers to format their work as it appears in the script to cut down on time wasted. There was a massive time improvement from this. I was tempted to just write a script to convert their format of (IIRC):
Rosa blah blah gardening tomato
to
R "blah blah gardening tomato"

but I never got around to it and the change was so minor and easy to get to for the writing side that I just told them to type in that format.

IMO that should be done with at least some supervision, input or feedback from the original author.

Generally speaking, I'd just record a video of the output and send it to the writers and artists for judgement. If they complained, I fixed, if not, then it was good enough.

>I can see this being a long slog, but live script reloading should take some of the edge off. Trust me man, i've been using that since I discovered it while working on chapter 2. >what was your experience of debugging the stage directions when you were battling alone, did you settle on a comfortable workflow? Mostly, it was as follows: 1. Imagine what each of the characters would look like in certain places 2. Put sprites on screen in places I think they'll go 3. Reload the scene and check out if somethings wrong 4. If it is, correct slowly until I moved on This was tedius, took way too much time, and, near the end, Some of the more granular control was simply not time effective (we were aiming for /v/3). The entire process of coreography is very time consuming and with little shortcuts. I only really fixed what was complained about and no one really complained about what was wrong until near the end. >I was also wondering if the scope here is limited to VFX, sprite control and that or whether it extends to text tagging as well I used to manually tag text in chapter 1 until I realized how utterly miserable it was. From there, I told the writers to format their work as it appears in the script to cut down on time wasted. There was a massive time improvement from this. I was tempted to just write a script to convert their format of (IIRC): Rosa blah blah gardening tomato to R "blah blah gardening tomato" but I never got around to it and the change was so minor and easy to get to for the writing side that I just told them to type in that format. >IMO that should be done with at least some supervision, input or feedback from the original author. Generally speaking, I'd just record a video of the output and send it to the writers and artists for judgement. If they complained, I fixed, if not, then it was good enough.

Bowie commented

2021-06-18 06:58:47 +00:00

printing_suicide_note_third_revised.png

Thanks for the lowdown, to postpone kysing myself I'll probably try looking into custom keybindings to do stuff like highlight segments of dialogue and hit ctrl+i to get the IDE to stick {i}{/i} tags around the selection etc.

Speaking of which, what's everyone's dev enviroment like? I threw together a short shitposty scene in npp but I'd definitely like something a little comfier that can support Renpy syntax highlighting at the bare minimum.

printing_suicide_note_third_revised.png Thanks for the lowdown, to postpone kysing myself I'll probably try looking into custom keybindings to do stuff like highlight segments of dialogue and hit ctrl+i to get the IDE to stick `{i}{/i}` tags around the selection etc. Speaking of which, what's everyone's dev enviroment like? I threw together a short shitposty scene in npp but I'd definitely like something a little comfier that can support Renpy syntax highlighting at the bare minimum.

MichaelYick commented

2021-06-18 20:54:57 +00:00

Speaking of which, what's everyone's dev enviroment like?

I use Neovim with COC. It has python highlighting and Ren'py without any plugins. COC does code autocompletion (back when I worked in java this was a life saver). Renpy text highlighting for scripts is a bit less than steller, but it gets the job done. Vim macros are cool to if you need to get a job done quickly. If you get past the learning curve, vim is pretty good.
I'd suggest learning it and then learning macros. From there more complex things can be learned.
A tutorial on vim macros

>Speaking of which, what's everyone's dev enviroment like? I use Neovim with [COC](https://github.com/neoclide/coc.nvim). It has python highlighting and Ren'py without any plugins. COC does code autocompletion (back when I worked in java this was a life saver). Renpy text highlighting for scripts is a bit less than steller, but it gets the job done. Vim macros are cool to if you need to get a job done quickly. If you get past the learning curve, vim is pretty good. I'd suggest learning it and then learning macros. From there more complex things can be learned. [A tutorial on vim macros](https://videos.lukesmith.xyz/videos/watch/a78d624a-0d5f-4012-aee0-2d98531e9c0b)

MichaelYick referenced a pull request that will close this issue

2021-06-21 22:13:50 +00:00

WIP: Fixes #12 - Coreography Update #40

MichaelYick added this to the Monster-Update-6 milestone 2021-06-21 22:15:08 +00:00

nutbuster referenced a pull request that will close this issue

2021-10-09 20:20:31 +00:00

Choreography changes Closes: #12 #82

nutbuster commented

2021-10-10 02:50:19 +00:00

i just forced commit the changes

nutbuster closed this issue

2021-10-10 02:50:19 +00:00