Lint errors in script #23

Closed
opened 4 months ago by StellarStellas · 6 comments

So I was going to write a tool to extract stuff from the script to find those missing image that sometimes pop-up. Then I read the renpy docs and found they already have a tool for that. So here's the output of the lint tool at current master (c61f3b3). I would fix it myself but it sounds like you guys are doing massive edits to clean up the project structure so I didn't want to waste my time.

game/script.rpy:115 Image fangsilo uses file 'fang/fang neutral.png', which is not loadable.

game/script.rpy:116 Image fangangrysilo uses file 'fang/fang angry.png', which is not loadable.

game/script.rpy:195 Image stella shock alt flip uses file 'stella/stella shocked alt.png', which is not loadable.

game/script.rpy:257 Image fang embarrass flip uses file 'fang/emotive set/fang embarrass.png', which is not loadable.

game/script.rpy:7242 Close text tag '/i' does not match open text tag 'alpha'. (in "{i}{alpha=0.5}She’s still family.{/i}{/alpha}")

game/script.rpy:8550 One or more text tags were left open at the end of the string: 'alpha', 'i' (in "{alpha=0.5}{i}If there’s anything Fang needs in these trying times, it’s a new friend to talk to!")

game/script.rpy:11046 'dimstage' is not an image.

game/script.rpy:14610 One or more text tags were left open at the end of the string: 'i' (in "{i}Anon: No. On an unrelated matter, have you spoken with Naser recently?")

game/script.rpy:21835 One or more text tags were left open at the end of the string: 'i' (in "{i}Stella’s chattering with me about the esoteric while the school delinquents get the Orwellian treatment from Rosa, who swaps between helping Fang plant some kind of exotic flower I don’t know and barking orders.")

game/script.rpy:21837 One or more text tags were left open at the end of the string: 'i' (in "{i}I understand maybe a third of what Stella’s saying and mostly just nod along.")

game/script.rpy:21839 One or more text tags were left open at the end of the string: 'i' (in "{i}-nights really important because the moon will be in perfect alignment for my divinations.")

game/script.rpy:21841 One or more text tags were left open at the end of the string: 'i' (in "{i}Right, right. Lunar eclipse. Is that the one where you can’t see the Moon or the one where you can’t see the sun?")

game/script.rpy:21849 One or more text tags were left open at the end of the string: 'i' (in "{i}I feel as though my divinations will be at their best under it’s crimson glow.")

game/script.rpy:21917 u'audio/OST/Fuck You I Like This Chick.oggs' is not loadable

game/script.rpy:22901 One or more text tags were left open at the end of the string: 'i', 'i' (in "She {i}was{i} fine, Trish. Now look what you’ve done.")

game/script.rpy:22917 One or more text tags were left open at the end of the string: 'i', 'i' (in "God dammit, why’d you have to pull this stunt {i}today{i} of all days?")

game/script.rpy:24360 The image tag 'farnsworthflip' is not the prefix of a declared image, nor was it used in a show statement before this hide statement.
So I was going to write a tool to extract stuff from the script to find those missing image that sometimes pop-up. Then I read the renpy docs and found they already have a tool for that. So here's the output of the lint tool at current master (c61f3b3). I would fix it myself but it sounds like you guys are doing massive edits to clean up the project structure so I didn't want to waste my time. ``` game/script.rpy:115 Image fangsilo uses file 'fang/fang neutral.png', which is not loadable. game/script.rpy:116 Image fangangrysilo uses file 'fang/fang angry.png', which is not loadable. game/script.rpy:195 Image stella shock alt flip uses file 'stella/stella shocked alt.png', which is not loadable. game/script.rpy:257 Image fang embarrass flip uses file 'fang/emotive set/fang embarrass.png', which is not loadable. game/script.rpy:7242 Close text tag '/i' does not match open text tag 'alpha'. (in "{i}{alpha=0.5}She’s still family.{/i}{/alpha}") game/script.rpy:8550 One or more text tags were left open at the end of the string: 'alpha', 'i' (in "{alpha=0.5}{i}If there’s anything Fang needs in these trying times, it’s a new friend to talk to!") game/script.rpy:11046 'dimstage' is not an image. game/script.rpy:14610 One or more text tags were left open at the end of the string: 'i' (in "{i}Anon: No. On an unrelated matter, have you spoken with Naser recently?") game/script.rpy:21835 One or more text tags were left open at the end of the string: 'i' (in "{i}Stella’s chattering with me about the esoteric while the school delinquents get the Orwellian treatment from Rosa, who swaps between helping Fang plant some kind of exotic flower I don’t know and barking orders.") game/script.rpy:21837 One or more text tags were left open at the end of the string: 'i' (in "{i}I understand maybe a third of what Stella’s saying and mostly just nod along.") game/script.rpy:21839 One or more text tags were left open at the end of the string: 'i' (in "{i}-nights really important because the moon will be in perfect alignment for my divinations.") game/script.rpy:21841 One or more text tags were left open at the end of the string: 'i' (in "{i}Right, right. Lunar eclipse. Is that the one where you can’t see the Moon or the one where you can’t see the sun?") game/script.rpy:21849 One or more text tags were left open at the end of the string: 'i' (in "{i}I feel as though my divinations will be at their best under it’s crimson glow.") game/script.rpy:21917 u'audio/OST/Fuck You I Like This Chick.oggs' is not loadable game/script.rpy:22901 One or more text tags were left open at the end of the string: 'i', 'i' (in "She {i}was{i} fine, Trish. Now look what you’ve done.") game/script.rpy:22917 One or more text tags were left open at the end of the string: 'i', 'i' (in "God dammit, why’d you have to pull this stunt {i}today{i} of all days?") game/script.rpy:24360 The image tag 'farnsworthflip' is not the prefix of a declared image, nor was it used in a show statement before this hide statement. ```

this is a goldmine and i'm mad at myself for not doing this earlier. big thanks - will definitely look to get these incorporated alongside all the other patches/tweaks going on right now

this is a goldmine and i'm mad at myself for not doing this earlier. big thanks - will definitely look to get these incorporated alongside all the other patches/tweaks going on right now

do you mind posting the documentation for this tool from the renpy wiki? Would be a massive help for issue no #22 and the quality assurance section of it.

do you mind posting the documentation for this tool from the renpy wiki? Would be a massive help for issue no #22 and the quality assurance section of it.
PrincipalSpears added the
bug
High Priority
labels 4 months ago

I found it in the quickstart guide for renpy https://www.renpy.org/doc/html/quickstart.html
It seems to require you to open the project with the renpy launcher, then just click "Check Script".
The code is in renpy/lint.py in the renpy sdk, but it doesn't seem to be designed as a standalone script, I think it gets called from somewhere else after the project has been setup so it knows where to look for assets and stuff.

I found it in the quickstart guide for renpy https://www.renpy.org/doc/html/quickstart.html It seems to require you to open the project with the renpy launcher, then just click "Check Script". The code is in `renpy/lint.py` in the renpy sdk, but it doesn't seem to be designed as a standalone script, I think it gets called from somewhere else after the project has been setup so it knows where to look for assets and stuff.

I've never dived too deeply into it, but the company I work for standard practice is to just run things through LINTs standard ruleset, although I know they can be tweaked. It's great for syntax errors, null pointers, etc. High # of false flags on larger projects though.

I've never dived too deeply into it, but the company I work for standard practice is to just run things through LINTs standard ruleset, although I know they can be tweaked. It's great for syntax errors, null pointers, etc. High # of false flags on larger projects though.

#17 should now fix all of this except dimstage

https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/17 should now fix all of this except `dimstage`

#17 has been merged.

https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/17 has been merged.
PrincipalSpears closed this issue 4 months ago
PrincipalSpears added this to the Patchy-Patch5 Release milestone 4 months ago
Sign in to join this conversation.
No project
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.