Cavemanon
/
SnootGame
24
0
Fork 15
Code Issues 2 Pull Requests 2 Projects Releases 4 Wiki Activity

Closes: lazysnake/feature/ISSUE-3_CG_Gallery #3 #55

Closed
nutbuster wants to merge 50 commits from lazysnake/feature/ISSUE-3_CG_Gallery into Monster-Update-6
pull from: lazysnake/feature/ISSUE-3_CG_Gallery
merge into: Cavemanon:Monster-Update-6
Conversation 4 Commits 50 Files Changed 15 +220 -121
nutbuster commented 2021-07-11 01:19:31 +00:00
Member
Copy Link

Related to: #14
Ideally I would PR into Snake's branch but I can't for some reason.

Already fixed:
SDK problem, you can freely run the SDK from any location and no more imported libraries or stackoverflow code.
Removed the multiple copy and paste re-definitions of main_menu related styles
Removed unused cg images (see unused.png)
Merged with monster-update-6

Will fix a few thing like:
Gallery menu
Extra menu - replace all the ui buttons with the images similar to the UI Overhaul
Removal of all instances of unlockcg(), RenPy's seen_image() is effective enough

Related to: #14 Ideally I would PR into Snake's branch but I can't for some reason. Already fixed: SDK problem, you can freely run the SDK from any location and no more imported libraries or stackoverflow code. **Removed the multiple copy and paste re-definitions of main_menu related styles** Removed unused cg images (see unused.png) Merged with monster-update-6 Will fix a few thing like: Gallery menu Extra menu - replace all the ui buttons with the images similar to the UI Overhaul Removal of all instances of unlockcg(), RenPy's seen_image() is effective enough
unused.png
4.2 KiB
unused.png
nutbuster added 40 commits 2021-07-11 01:19:32 +00:00
059a1381bb Remove the Nth times the style was redefined 
DO NOT REDEFINE STYLES MULTIPLE TIMES
DO NOT REDEFINE STYLES MULTIPLE TIMES
DO NOT REDEFINE STYLES MULTIPLE TIMES
DO NOT REDEFINE STYLES MULTIPLE TIMES
DO NOT REDEFINE STYLES MULTIPLE TIMES
nutbuster added 6 commits 2021-07-11 03:54:19 +00:00
nutbuster added 1 commit 2021-07-11 04:02:30 +00:00
nutbuster added 1 commit 2021-07-11 05:11:40 +00:00
nutbuster added 1 commit 2021-07-11 05:18:39 +00:00
nutbuster commented 2021-07-11 05:24:59 +00:00
Author
Member
Copy Link

Gallery Menu works, it is more functional than ever - loads all of the images and dumps them into a grid 3col * how many rows it needs

str = "renpy.seen_image('"+imageName+"')"
g.condition(str)

Solves a lot of problems, g.unlock and similar gallery functions are very easy to misread what they actually intend to do.

Unlockcg() has been reverted in script files, all instances has been cleanly removed
Extra menus have been re-done similar to the UI Overhaul

Gallery Menu works, it is more functional than ever - loads all of the images and dumps them into a grid 3col * how many rows it needs ``` str = "renpy.seen_image('"+imageName+"')" g.condition(str) ``` Solves a lot of problems, g.unlock and similar gallery functions are very easy to misread what they actually intend to do. Unlockcg() has been reverted in script files, all instances has been cleanly removed Extra menus have been re-done similar to the UI Overhaul
gallery_ascend.png
453 KiB
gallery_97.png
238 KiB
gallery_ascend.png gallery_97.png
nutbuster changed title from WIP: lazysnake/feature/ISSUE-3_CG_Gallery #3 to Closes: lazysnake/feature/ISSUE-3_CG_Gallery #3 2021-07-11 05:25:13 +00:00
nutbuster added 1 commit 2021-07-12 00:59:15 +00:00
coolestskinnieinthejungle commented 2021-07-12 03:14:34 +00:00
Member
Copy Link

great work everyone. going to start vetting this and if everything seems a-okay will get it integrated and set up for a point release (5.2 or something)

great work everyone. going to start vetting this and if everything seems a-okay will get it integrated and set up for a point release (5.2 or something)
coolestskinnieinthejungle commented 2021-07-14 03:41:16 +00:00
Member
Copy Link

heads up probably wont be able to get around to vetting til thursday just for awareness, real life consequences

heads up probably wont be able to get around to vetting til thursday just for awareness, real life consequences
coolestskinnieinthejungle added this to the Patchy-Patch5.1.1 milestone 2021-07-16 21:36:11 +00:00
coolestskinnieinthejungle commented 2021-07-16 21:46:48 +00:00
Member
Copy Link

thanks again for this and bearing with my shitty PMing
merged this into its own new branch 5.1.1 rather than Monster Update 6 as there's a lot of good stuff here we dont want to keep waiting.

8c4177438b

https://git.snootgame.xyz/Cavemanon/SnootGame/src/branch/5.1.1

thanks again for this and bearing with my shitty PMing merged this into its own new branch `5.1.1` rather than `Monster Update 6` as there's a lot of good stuff here we dont want to keep waiting. https://git.snootgame.xyz/Cavemanon/SnootGame/commit/8c4177438bba494f551ef72e6eb6bdef04782935 https://git.snootgame.xyz/Cavemanon/SnootGame/src/branch/5.1.1
nutbuster deleted branch lazysnake/feature/ISSUE-3_CG_Gallery 2021-09-16 01:25:00 +00:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
Critical Priority

Absolutely urgent issues that must be delt with before others can even be considered.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High Priority

Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.

  
Low Priority

Minor or easy to miss errors. Features that'd be nice, but can be done with out.

  
Medium Priority

Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount

  
Meta

for all the other fun stuff about the project thats not code

  
needs more info

Something is wrong

  
question

   
refactor

Cleaning up the cruft

  
wontfix

This won't be fixed

  
bug

Something is not working

  
Critical Priority

Absolutely urgent issues that must be delt with before others can even be considered.

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
High Priority

Bugs that cause crashes, major story errors, or other massively negative issues. Features that are a must-have inclusion or else the game won't be as good.

  
invalid

Something is wrong

  
Low Priority

Minor or easy to miss errors. Features that'd be nice, but can be done with out.

  
Medium Priority

Errors that stick out, but aren't fatal to gameplay. Features that are in decent demand or would improve gameplay by a signifigant amount

  
Meta

for all the other fun stuff about the project thats not code

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
Low Priority
Medium Priority
Meta
needs more info
question
refactor
wontfix
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
invalid
Low Priority
Medium Priority
Meta
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Patchy-Patch5.1.1
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Cavemanon/SnootGame#55
No description provided.
Delete Branch "lazysnake/feature/ISSUE-3_CG_Gallery"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?