GUI text color revamp #57

Closed
opened 3 months ago by coolestskinnieinthejungle · 17 comments
Collaborator

in the submenus (specifically the ones that pop out on the menu and don't dim the bg like updates, about, etc.) the text is that color of hot pink and it looks like shit cus it's bright text on bright bg

i tried to fuck around and declare a separate "dark/submenu" text schema but didnt have much time and didnt really get anywhere. i'm a ui/ux brainlet by choice i swear

anyway would appreciate it if someone could take a stab at this.

in the submenus (specifically the ones that pop out on the menu and don't dim the bg like updates, about, etc.) the text is that color of hot pink and it looks like shit cus it's bright text on bright bg i tried to fuck around and declare a separate "dark/submenu" text schema but didnt have much time and didnt really get anywhere. i'm a ui/ux brainlet by choice i swear anyway would appreciate it if someone could take a stab at this.
coolestskinnieinthejungle added this to the Monster-Update-6 milestone 3 months ago
coolestskinnieinthejungle added the
Medium Priority
label 3 months ago
Collaborator

I can tweak this.

I can tweak this.
Collaborator

I have tweaked the colors, just to see if this works. (See attachment. Changed the gui.accent_color and gui.idle_color parameters.)

Alternatively, if this doesn't work/is not enough, I can look into dimming the bg of the vbox that houses them. I just kinda feel like that might be more out of place. (Also, my fork is out of date. How do I update it with the least amount of pain? I don't want to preserve what I did on my local.)

I have tweaked the colors, just to see if this works. (See attachment. Changed the gui.accent_color and gui.idle_color parameters.) Alternatively, if this doesn't work/is not enough, I can look into dimming the bg of the vbox that houses them. I just kinda feel like that might be more out of place. (Also, my fork is out of date. How do I update it with the least amount of pain? I don't want to preserve what I did on my local.)
Collaborator

Alternatively, if this doesn't work/is not enough, I can look into dimming the bg of the vbox that houses them. I just kinda feel like that might be more out of place. (Also, my fork is out of date. How do I update it with the least amount of pain? I don't want to preserve what I did on my local.)

@Nio, git fetch & git pull & git merge the Monster-Update-6 branch, if you get into a merge conflict you'll have to use git mergetool and fumble about (although if you do mess up and don't actually deal with merges properly, at worst it writes both the new and old differences and you can just manually edit them out and commit)

I recall from the ren'py docs you can do image transformations with Image('filename.png', then whatever arguments) there's examples in the script.rpy with transforming existing character images to black silhouettes

> Alternatively, if this doesn't work/is not enough, I can look into dimming the bg of the vbox that houses them. I just kinda feel like that might be more out of place. (Also, my fork is out of date. How do I update it with the least amount of pain? I don't want to preserve what I did on my local.) @Nio, `git fetch` & `git pull` & `git merge` the `Monster-Update-6` branch, if you get into a merge conflict you'll have to use git mergetool and fumble about (although if you do mess up and don't actually deal with merges properly, at worst it writes both the new and old differences and you can just manually edit them out and commit) I recall from the ren'py docs you can do image transformations with Image('filename.png', then whatever arguments) there's examples in the `script.rpy` with transforming existing character images to black silhouettes
Collaborator

@Nio, git fetch & git pull & git merge the Monster-Update-6 branch, if you get into a merge conflict you'll have to use git mergetool and fumble about (although if you do mess up and don't actually deal with merges properly, at worst it writes both the new and old differences and you can just manually edit them out and commit)

Thank you! Git is kinda hard to get (at least for me), so I will look into the commands you posted. It didn't seem to work off the bat, so I just downloaded Monster-Update-6 and mongoloid overwrote the local of the fork of mine. I think this should work. Not as elegant and I only hope that Git won't have a seizure over it.

I recall from the ren'py docs you can do image transformations with Image('filename.png', then whatever arguments) there's examples in the script.rpy with transforming existing character images to black silhouettes

Thanks , will look into this and post the screenshots so we can decide which one we like better.

> @Nio, `git fetch` & `git pull` & `git merge` the `Monster-Update-6` branch, if you get into a merge conflict you'll have to use git mergetool and fumble about (although if you do mess up and don't actually deal with merges properly, at worst it writes both the new and old differences and you can just manually edit them out and commit) Thank you! Git is kinda hard to get (at least for me), so I will look into the commands you posted. It didn't seem to work off the bat, so I just downloaded Monster-Update-6 and mongoloid overwrote the local of the fork of mine. I think this should work. Not as elegant and I only hope that Git won't have a seizure over it. > I recall from the ren'py docs you can do image transformations with Image('filename.png', then whatever arguments) there's examples in the `script.rpy` with transforming existing character images to black silhouettes Thanks , will look into this and post the screenshots so we can decide which one we like better.
Collaborator

Monster-Update-6 doesn't seem to contain the new menu. Patchy-patch-5 does. I'm confused.

I could work off of Patchy-patch-5, we just need a Principal decision regarding which direction are we going with.

Monster-Update-6 doesn't seem to contain the new menu. Patchy-patch-5 does. I'm confused. I could work off of Patchy-patch-5, we just need a Principal decision regarding which direction are we going with.
Collaborator

Monster-Update-6 doesn't seem to contain the new menu. Patchy-patch-5 does. I'm confused.

@Nio, As far as I see it Patchy-patch-5 is more or less done or 'final',
Since Monster-Update-6 was a seperate branch it didn't really pull/merge from Patchy-patch-5 at all during development, the Gallery Branch #55 I have has dealt with the merge conflicts & changes from gallery (Patchy-patch-5) into Monster-Update-6. Worst case scenario, any development is 'frozen' as @coolestskinnieinthejungle was going to review the Gallery pull request

> Monster-Update-6 doesn't seem to contain the new menu. Patchy-patch-5 does. I'm confused. @Nio, As far as I see it Patchy-patch-5 is more or less done or 'final', Since Monster-Update-6 was a seperate branch it didn't really pull/merge from Patchy-patch-5 at all during development, the Gallery Branch #55 I have has dealt with the merge conflicts & changes from gallery (Patchy-patch-5) into Monster-Update-6. Worst case scenario, any development is 'frozen' as @coolestskinnieinthejungle was going to review the Gallery pull request
Collaborator

Monster-Update-6 doesn't seem to contain the new menu. Patchy-patch-5 does. I'm confused.

@Nio, As far as I see it Patchy-patch-5 is more or less done or 'final',
Since Monster-Update-6 was a seperate branch it didn't really pull/merge from Patchy-patch-5 at all during development, the Gallery Branch #55 I have has dealt with the merge conflicts & changes from gallery (Patchy-patch-5) into Monster-Update-6. Worst case scenario, any development is 'frozen' as @coolestskinnieinthejungle was going to review the Gallery pull request

Should I base my fork on PP5 and then the difference can be added to MU6? I don't think it'll have actual conflicts if PP5 is the way forward.

> > Monster-Update-6 doesn't seem to contain the new menu. Patchy-patch-5 does. I'm confused. > > @Nio, As far as I see it Patchy-patch-5 is more or less done or 'final', > Since Monster-Update-6 was a seperate branch it didn't really pull/merge from Patchy-patch-5 at all during development, the Gallery Branch #55 I have has dealt with the merge conflicts & changes from gallery (Patchy-patch-5) into Monster-Update-6. Worst case scenario, any development is 'frozen' as @coolestskinnieinthejungle was going to review the Gallery pull request > > Should I base my fork on PP5 and then the difference can be added to MU6? I don't think it'll have actual conflicts if PP5 is the way forward.
Collaborator

Should I base my fork on PP5 and then the difference can be added to MU6? I don't think it'll have actual conflicts if PP5 is the way forward.

@Nio, you could try doing something jank like this:
Work on PP5 branch and then wait for the Gallery PR into MU6 to be done.
Once you're ready to pull MU6 into your PP5 branch: if you do run into a merge conflict do git merge --abort; git reset HEAD^, then git stash, then git branch [MU6] [MU6]; git checkout [MU6]; git pull [MU6], then git stash pop and finally git add ; git commit
I forget if git can automatically acutally figure this thing out by itself when pulling but best to be a bit 'manual' in the apporach

> Should I base my fork on PP5 and then the difference can be added to MU6? I don't think it'll have actual conflicts if PP5 is the way forward. @Nio, you could try doing something jank like this: Work on PP5 branch and then wait for the Gallery PR into MU6 to be done. Once you're ready to pull MU6 into your PP5 branch: if you do run into a merge conflict do `git merge --abort; git reset HEAD^`, then `git stash`, then `git branch [MU6] [MU6]; git checkout [MU6]; git pull [MU6]`, then `git stash pop` and finally `git add ; git commit` I forget if git can automatically acutally figure this thing out by itself when pulling but best to be a bit 'manual' in the apporach
Collaborator

OK, here is the panel and the menu for the Extras segment darkened to -0.3 .
Let me know what you prefer, @coolestskinnieinthejungle this or the more muted colors.

OK, here is the panel and the menu for the Extras segment darkened to -0.3 . Let me know what you prefer, @coolestskinnieinthejungle this or the more muted colors.
Poster
Collaborator

i like the latter, thanks for being so quick about this guys. i'll consult with the artfags and get their opinions too

UPDATE:
so the consensus seems to prefer the first example (darker text), although only other concern is if that shade of gray could be darkened a bit (Update Now button)

i like the latter, thanks for being so quick about this guys. i'll consult with the artfags and get their opinions too UPDATE: so the consensus seems to prefer the first example (darker text), although only other concern is if that shade of gray could be darkened a bit (Update Now button)
coolestskinnieinthejungle removed this from the Monster-Update-6 milestone 3 months ago
Poster
Collaborator

@Nio @nutbuster
sorry for the confusion re: the branches that's entirely my bad. i would just work off of a fork of master right now for this one as patchy-patch5 is outdated. didn't wanna delete it yet JIC

@Nio @nutbuster sorry for the confusion re: the branches that's entirely my bad. i would just work off of a fork of master right now for this one as patchy-patch5 is outdated. didn't wanna delete it yet JIC
Collaborator

i like the latter, thanks for being so quick about this guys. i'll consult with the artfags and get their opinions too

UPDATE:
so the consensus seems to prefer the first example (darker text), although only other concern is if that shade of gray could be darkened a bit (Update Now button)

OK, I will apply the darker text colors and darken the Update Now button's font color as well. Will post a pic of this here, just to be sure.

(Might be delayed a few hours, at work atm.)

> i like the latter, thanks for being so quick about this guys. i'll consult with the artfags and get their opinions too > > > UPDATE: > so the consensus seems to prefer the first example (darker text), although only other concern is if that shade of gray could be darkened a bit (Update Now button) OK, I will apply the darker text colors and darken the Update Now button's font color as well. Will post a pic of this here, just to be sure. (Might be delayed a few hours, at work atm.)
Collaborator

So, I added the new colors, see the samples.

As for the update button thing, I realized that I was not using master to demonstrate earlier (albeit it doesn't matter much) in the current version the grey part is not present.

Also there is some font color redef in the Update screen, do we want to keep it like this? Or perhaps choose a color out of the two?

I pushed the changes to my fork's master (which should be now up to date with the live Master).

So, I added the new colors, see the samples. As for the update button thing, I realized that I was not using master to demonstrate earlier (albeit it doesn't matter much) in the current version the grey part is not present. Also there is some font color redef in the Update screen, do we want to keep it like this? Or perhaps choose a color out of the two? I pushed the changes to my fork's master (which should be now up to date with the live Master).
Poster
Collaborator

@Nio this is awesome. also i've been reviewing the great work on @nutbuster 's pr #55.

i'm thinking the best way to get all changes packaged together would be to use the outlining of text + expanded menus on that PR, and your muted color definitions on this PR/issue.

also you can throw out the manual redefs for the font colors - i only put those there temporarily to stop my eyes from burning.

thanks again both of you. no rush on this at all. probably going to be releasing a point update version very soon 5.1.1 that could include both this and potentially the gallery as a heads up

@Nio this is awesome. also i've been reviewing the great work on @nutbuster 's pr https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/55. i'm thinking the best way to get all changes packaged together would be to use the outlining of text + expanded menus on that PR, and your muted color definitions on this PR/issue. also you can throw out the manual redefs for the font colors - i only put those there temporarily to stop my eyes from burning. thanks again both of you. no rush on this at all. probably going to be releasing a point update version very soon `5.1.1` that could include both this and potentially the gallery as a heads up
coolestskinnieinthejungle added this to the Patchy-Patch5.1.1 milestone 3 months ago
Poster
Collaborator

appreciate you guys dealing with my (lack of) PM refinement lol

consulted with the head honchos we're going to take the great work done sofar and do a point release. https://git.snootgame.xyz/Cavemanon/SnootGame/src/branch/5.1.1 created and #55 closed effectively.

@Nio your color changes should (hopefully) be transferrable over to 5.1.1, apologies for flinging you around and appreciate the continued cooperation.
if you have any issues or need help let me know here or shoot me an email. i get notifications set up for the latter on my daily driver box (i only dev and use gitea on my dev box)

appreciate you guys dealing with my (lack of) PM refinement lol consulted with the head honchos we're going to take the great work done sofar and do a point release. https://git.snootgame.xyz/Cavemanon/SnootGame/src/branch/5.1.1 created and https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/55 closed effectively. @Nio your color changes should (hopefully) be transferrable over to `5.1.1`, apologies for flinging you around and appreciate the continued cooperation. if you have any issues or need help let me know here or shoot me an email. i get notifications set up for the latter on my daily driver box (i only dev and use gitea on my dev box)
Collaborator

appreciate you guys dealing with my (lack of) PM refinement lol

consulted with the head honchos we're going to take the great work done sofar and do a point release. https://git.snootgame.xyz/Cavemanon/SnootGame/src/branch/5.1.1 created and #55 closed effectively.

@Nio your color changes should (hopefully) be transferrable over to 5.1.1, apologies for flinging you around and appreciate the continued cooperation.
if you have any issues or need help let me know here or shoot me an email. i get notifications set up for the latter on my daily driver box (i only dev and use gitea on my dev box)

@coolestskinnieinthejungle no worries, I'm happy to accommodate whatever needs to be done on my end as best I can.

I pushed the unified color selection to my master so now the menu should have the muted font colors.
Do you need anything else from my fork? (e.g. adding the outlining format or something else)

EDIT: I see pretty much everything is in there. Still if you want me to add something else as well, feel free to say so.

> appreciate you guys dealing with my (lack of) PM refinement lol > > consulted with the head honchos we're going to take the great work done sofar and do a point release. https://git.snootgame.xyz/Cavemanon/SnootGame/src/branch/5.1.1 created and https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/55 closed effectively. > > @Nio your color changes should (hopefully) be transferrable over to `5.1.1`, apologies for flinging you around and appreciate the continued cooperation. > if you have any issues or need help let me know here or shoot me an email. i get notifications set up for the latter on my daily driver box (i only dev and use gitea on my dev box) @coolestskinnieinthejungle no worries, I'm happy to accommodate whatever needs to be done on my end as best I can. I pushed the unified color selection to my master so now the menu should have the muted font colors. Do you need anything else from my fork? (e.g. adding the outlining format or something else) EDIT: I see pretty much everything is in there. Still if you want me to add something else as well, feel free to say so.
Poster
Collaborator

wicked, ty. colors looks much better now, easier on the eyes.
merged and put into 5.1.1

wicked, ty. colors looks much better now, easier on the eyes. merged and put into `5.1.1`
Sign in to join this conversation.
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
There is no content yet.