Mobile Versions of the game have a wonk GUI due to hard-coded coordinates for textboxes #8

New Issue

MichaelYick · 2021-06-13T01:40:45Z

MichaelYick commented

2021-06-13 01:40:45 +00:00

Much of the game's spriting for textbox and menus is hard-coded to depend on 1920x1080 resolution and simply scaling to that. This can be seen in Android builds of the game if you compile to it.

Much of the game's spriting for textbox and menus is hard-coded to depend on 1920x1080 resolution and simply scaling to that. This can be seen in Android builds of the game if you compile to it. ![image]()

image.png

306 KiB

MichaelYick added the

enhancement

label 2021-06-13 01:40:45 +00:00

MichaelYick added

bug

and removed

enhancement

labels 2021-06-13 01:41:56 +00:00

MichaelYick added the

High Priority

label 2021-06-13 01:54:38 +00:00

MichaelYick added this to the (deleted) milestone 2021-06-13 02:07:03 +00:00

MichaelYick added this to the Monster-Update-6 milestone 2021-06-23 23:10:57 +00:00

Nio commented

2021-06-30 13:52:22 +00:00

Hey, should I create a new fork for this one?
I think that the namebox positioning can be solved with something like:

style namebox:
    variant "small"
    xalign 0.15
    xsize gui.namebox_width
    ysize gui.namebox_height
    ypos gui.name_ypos

This seems to work well.

Are there other notable issues? I think I'll just try and scour the game for any misplacements.

Hey, should I create a new fork for this one? I think that the namebox positioning can be solved with something like: ``` style namebox: variant "small" xalign 0.15 xsize gui.namebox_width ysize gui.namebox_height ypos gui.name_ypos ``` This seems to work well. Are there other notable issues? I think I'll just try and scour the game for any misplacements.

nutbuster referenced a pull request that will close this issue

2021-06-30 21:16:37 +00:00

Fixes: #8 - Namebox position for mobile #45

MichaelYick commented

2021-06-30 23:34:06 +00:00

Hey, should I create a new fork for this one?
I think that the namebox positioning can be solved with something like:
style namebox:
    variant "small"
    xalign 0.15
    xsize gui.namebox_width
    ysize gui.namebox_height
    ypos gui.name_ypos
This seems to work well.

Are there other notable issues? I think I'll just try and scour the game for any misplacements.

Where exactly would this go? If it does fix it, then please do make a fork.

> Hey, should I create a new fork for this one? > I think that the namebox positioning can be solved with something like: > > ``` > style namebox: > variant "small" > xalign 0.15 > xsize gui.namebox_width > ysize gui.namebox_height > ypos gui.name_ypos > ``` > > This seems to work well. > > Are there other notable issues? I think I'll just try and scour the game for any misplacements. Where exactly would this go? If it does fix it, then please do make a fork.

Nio commented

2021-07-01 00:07:32 +00:00

Where exactly would this go? If it does fix it, then please do make a fork.

In the Mobile Variants segment, if I define this minor tweak to the namebox style, the position of the text sits right where it ought to be.

And yep, making a fork. Should I base it on the current live master or one of the Patchy-Patch ones?

> Where exactly would this go? If it does fix it, then please do make a fork. In the Mobile Variants segment, if I define this minor tweak to the namebox style, the position of the text sits right where it ought to be. And yep, making a fork. Should I base it on the current live master or one of the Patchy-Patch ones?

MichaelYick commented

2021-07-01 01:17:54 +00:00

I suggest Monster Update. Also, maybe unify the stuff and see if this fix will work for both desktop and mobile. It'd really do a number on cleaning up the trashfire that is the script.rpy's start.

MichaelYick closed this issue

2021-07-01 05:49:45 +00:00

MichaelYick referenced this issue from a commit

2021-07-01 05:49:45 +00:00

Merge pull request 'Fixes: #8 - Namebox position for mobile' (#45) from nutbuster/SnootGame:Monster-Update-6 into Monster-Update-6

Sign in to join this conversation.