Replace "Help & About" with an extras menu that'll contain, help, about, updates, gallery, and more stuff. #19
Labels
No Label
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
Low Priority
Medium Priority
Meta
needs more info
question
refactor
wontfix
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
invalid
Low Priority
Medium Priority
Meta
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Cavemanon/SnootGame#19
Loading…
Reference in New Issue
No description provided.
Delete Branch "%!s(<nil>)"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Seems to be a "must implement" due to a number of PRs and issues we have going. Many PRs and issues depend on this.
Do we have the assets for the buttons? Like the any adobe/gimp project files? (.psd)
I think I figured out a new layout for the extras menu, essentially it keeps the main menu look and acts like a submenu, rather than being an entirely new looking screen. For this, I will need to make more buttons.
Also, maybe extras can have its own viewport thingy like the one for Options/Load/History etc? Or, we could use this as a shortcut to the functions but they would all be present on the same quick menu?
we got images (see this comment https://git.snootgame.xyz/PrincipalSpears/SnootGame/issues/14#issuecomment-105)
Seems good
I can get the blank button files from the artists if you think that'd be helpful
Might be good just to stylize it like the main menu and it replaces the buttons and game logo
Thank you, I'll check those out.
Yes please, this will make it considerably easier to make more buttons.
So, it would show content on the left and the navigation would stay on the right in a vbox of some sort when interacting with the extras. I think I understand what you mean.
moreso mean that the menu would look identical to the main menu except for the buttons are changed out to those help, about, updates gallery, etc.
Had a bit of a back and forth with git just now. It complaining that the master of my fork had changes that I didn't. Not sure if it was your stuff @PrincipalSpears, I hope I didn't mess it up. I pushed a test version of the general layout. Had a hard time yesterday figuring out positioning so progress was a little slow. I still need to figure out how to add a BG to the left panel. Under Extras, the Updates button has the submenu mostly positioned correctly.
Have a look and let me know if this is similar to what you have in mind, or I'm completely off the mark. If it is good, I can create the other pages the same way and then we can populate them.
Also, if you could make the blank buttons available that would be great. There seems to be a gradient on them that fades to see-through. That would be kinda hard to nail without the base.
Are we going to have different buttons for when the option belonging to it is selected?
Edit: I think I figured out a neat way to add some background to a few of the smaller options. Let me know what you think. We could widen it a bit more - gallery would definitely be a special case, with the wider grid layout.
Don't we all? Don't worry about it, git sucks.
You can't push to the main repo, my stuffs uneffected. The most you could do would be to your own fork or local git. Use
git reset --hard $where $ is where you want to go to return to what you were doing (assuming your working with a UNIX-like shell that is).its fine if you're leaning. Copy some of the main menu code and modify it from there. Play around with the code and see what changes, reset as needed. Don't worry about "messing things up", git is made so you can ditch changes at any time. If you're really lost, just
git clonethe repo again.forgot to harass artists about that, will do.
Maybe? If we have time we can.
MichaelYick referenced this issue2021-06-16 09:20:51 +00:00
just checked the code out, looks great. Keep working on it as usual. I made a PR on your behalf (https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/29) for ease of review, testing, etc.
Thank you, I am nearly finished with the first iteration of the Extras menu, bar the graphical elements and a bit of positioning for the Help subscreens. I have mocked up a pair of panel BGs based on the PNGs we already have. The larger one is not ideal, but without the originals (PSDs) it's the best I can do without redoing the whole thing. As soon as I have the buttons I'll create & add those as well.
Will push these changes tomorrow to my fork. (Technically today, over here.)
I was looking at the text in contrast with the new BGs, not sure if the magenta is the best for readability/looks - I'm no color expert though.
Next on my list is to delve further into the style statements to better understand what is defined where and how it takes effect and maybe streamline a few screens I added (trim the potentially unnecessary style statements).
@PrincipalSpears , harassing you just so that it is not forgotten. Please poke the artists for the assets so I can finish up making the buttons. I can also figure out a highlight/selected version of them (or at least mock up a few , so you can have a look if any takes your fancy).
@Nio here you go!
Thank you.
EDIT:
@PrincipalSpears , the rehauled menu pieces' 2nd iteration is ready, complete with new buttons.
Have a look please. One thing in particular, whether the Help and the About menu's background works with the font color.
Until you get back to me, I'll take a crack at the update action.
already got some work for it done on https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/21. You can test it out. I'll set up the VPS to have update.snootgame.xyz tomarrow.
Nice!
I am not used to working with forks a whole lot in git, how would I get #21's stuff in my repo?
Better yet, how are we going to marry up the Extras menu bit that I did with the Updates work?
The Updates page is just an example I put together to test panels and some ui bits, can be completely overridden (same with gallery, I just experimented with a possible layout).
EDIT:
Not sure if you otherwise see the reply, so pinging this way @PrincipalSpears .
I get notifications on everything that I create or have commneted on. I go through all of them one at a time.
Depends on your OS (assuming Windows by statistics and your past comments on Windows .ico files). But essentially theres a stupid useful set of programs called "git-extras" and they contain a tool called "git-pr". Just run
git-pr NUM-OF-PULLand it'll make a local branch of that PR. Install can be found here:https://github.com/tj/git-extras/blob/master/Installation.md
btw if you're using WSL, WSL2, or a VM to get a unix-like enviroment, follow the distro specific suggestions. (I.e if your VM or WSL is running on Debian, use the Debian instructions).
Im not working on the UI parts of update until this PR is done, so I'll just integrate my code with yours when the time comes. For the gallery, you should keep it a placeholder until https://git.snootgame.xyz/Cavemanon/SnootGame/pulls/14 is done.
Ah, OK.
Yeah, I'm doing the work on a windows machine, simply because it has my monitors hooked up to it.
I installed this, thanks. So, I can now clone a specific pr's payload, nice. Gonna have a look.
OK.
I'll revisit the style defs and the UI elements. I could do something similar for each buttons in the right side menu as we have on the in-game side menu (where it has the skip, load, auto etc) options when we hover over them and select them.
New button designs for selected_idle and selected_hover under Extras (Help and About).
Le me know if the designs fit, should we even have any sort of alts like these. I can tweak them, think up new ones or make ones from your ideas.
the help one is good if you make it a bit darker on the inside and on the edges.
Like a uniform darkening? See attachments (if it goes through this time).
EDIT:
Also, do you prefer the large panel to be uniform for the Extras menu or is it OK as is, with Updates having a smaller one?
Yeah that works
What do you mean by "large panel to be uniform for the extras menu", uniform in comparison to what? Can I get a visual?
OK, which one? I am leaning towards the less dark one out of the two that I attached previously.
Sure, the two attached files are both taken from options under the Extras menu. The Updates option has a narrow left side panel while the Help, About and Gallery all have a wider one.
I'd say both should be the half-pannels. Though, in the name of consistancy with the gallery, it might be wise to put each of these into a viewport. It also should make everything simple to work with and integrate too. If you don't think this will be a problem and think the side pannels are cool enough, then go for that. End the end, im going to let you have the call on this until we get some quality testing.
Yeah, the viewports sounds like a better idea so then we can just redirect the contents easily as they are ready.
I'll try to marry up this sidepanel design with it. Will work on this comes Monday (Sunday here atm).
as a total UI/UX brainlet (by choice) this looks really neat and is wizardry to me
Granted, I'm no UI/UX expert either, in this particular case, I think the only real wizardry is figuring out Ren'pys orientation system. Not as intuitive - hence the delays on my end for the viewporting.
Also, thought I'd create sub-screens for the Extras menu, so that it is more easy to deal with.
@PrincipalSpears , in order to not delay further the other, dependent issues I think the current version in my fork is fine to use - unless you have any specific issue with it.
The only thing that may be a problem is some of the font colors for about and the halfpanel/full panel thing. Not sure if it is a big deal.
For now I don't think that it is worth doing a viewport on the extras menu. Unless we want to introduce more options beneath extras for submenus.
If you'd like I can continue to tinker at it more, but as I said for the sake of moving along with things I think we can use as is.
EDIT: Also, thanks for the patience. I am learning a lot and having fun with it.
Good to know this thing is about ready! I'll check it out, tweak what I need (if I need to), and will add it to Patchy-Patch.