WIP: Choreography update for chapter 1 #41
No reviewers
Labels
No Label
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
Low Priority
Medium Priority
Meta
needs more info
question
refactor
wontfix
bug
Critical Priority
duplicate
enhancement
help wanted
High Priority
invalid
Low Priority
Medium Priority
Meta
question
wontfix
No Milestone
No project
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: Cavemanon/SnootGame#41
Loading…
Reference in New Issue
No description provided.
Delete Branch "chapter-1-choreo"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Conflicts should now be resolved as long as nothing else lands on Monster-Update-6 first.
Okay giving this a review for now. Comments so far:
for some reason, declaring volume of audio causes the game not to boot. Commented problematic lines out and offered substitute lines until this problem can be resolved
A couple of tweaks to enhance the /soul/ of the game or other issues.
(denoted by ###, describing what was changed or a suggested change)
For new sound effects, make sure they're under compatable license. (Public Domain, CC0, CC-BY, CC-BY-SA 4.0, etc). For CC-BY and CC-BY-SA's it's legally imperitive we attribute them. This can be seen in the LICENSE file. Rather our demise be from lawlsuits from Koop rather than lawlsuits from some random internet schizo who uploaded toiletshitting3.wav to the internet.
what is blinky thingy, I don't play visual novels.
I see the use of this new-fangled "MoveTransition" thing. Since this may be a mainstay, i'll add a comment on the first instance of it to the tips page.
Go for it, I doubt the writers will complain about the fix. If they do, it'll be on me.
anons are going to love this
For sound effects, aim for ogg files or convert to ogg.
For now looking great! Keep up the good work! Will push my minor changes to this pr for you to review over.
Cool, I'll have a look through the comments.
This is pretty unfortunate, appears to work on wangdows.
I realised early on when I was making text more 'speechlike' that it was sometimes quite jarring not knowing when a character had finished speaking and by extension not knowing when you should click to move on to the next segment of dialogue.
Luckily it turns out that Renpy has a built in feature to mitigate this problem in the form of 'click-to-continue indicators', where for each Character object you can define an icon that appears to prompt the player to move the dialogue forwards, for example once everything in the text window has been displayed. There was a small amount of discussion and it was suggested provisionally that we use a guitar pick - the position, size, animation and design of the indicator isn't at all final but I stuck it in anyway to see whether it would work as intended. It's super easy to tweak as well.
As for SFX, I'm out of my depth there and have been relying on the internal team to create stuff or sauce me up with something suitable. I'll keep all that in mind and take care though.
EDIT
I started preferring block ATL statements instead pretty quickly, since the stock easing functions you hand MoveTransition are poorly documented (as far as I could see). But yes, linear movement using 'with move' looks kind of whack IMO so I've been using easing wherever I can instead.
What version of renpy are you using? I'm on Devuan GNU/Linux and my repos may just have an old version of the SDK.
Useful, but users might find the blinking distracting. The human eye is attracted to movement and more often than not that will be there as users keep up with the text, detracting a bit from the visuals. Maybe just make it a faint symbol rather than a blinking one.
I'd suggest going to soundbible or similar sites, making sure the licensing is good-to-go, and then grabbing the noise. I found most of the sounds myself, it's easier than you'd think.
You had a stroke mid-paragraph, but from what I am getting, yeah it makes sense you'd prefer it. The move options nomrally are sorta limiting. No fault in using it, just that it needs to be documented. If you can, update the tips section as you find out more about the function.
assuming you're using the lastest SDK, it makes sense that stuff broke. Devuan's renpy version is woefully out of date.
I'm on 7.4.6
Yup, it was my renpy SDK. Uncomment the old stuff and remove the new fixes, i'll note this down for future reference.
Re-merged with the update branch so this should be ok to land if you're happy with the content. There are some minor TODOs and music choices could always be revised but everything else is there.
I'll branch off again and start chapter 2 if this gets the green light.
EDIT
Forgot about the CTC indicator, that shouldn't take much effort to rework.
Actually hold that thought, the guys want to review the SFX.
Ok all good.
will do a review soon(tm) and will merge this.
https://git.snootgame.xyz/Cavemanon/SnootGame/issues/63#issuecomment-887
Pull request closed